Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic plugin for page-ssr injection #4049

Merged
merged 6 commits into from
Aug 2, 2022
Merged

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Jul 26, 2022

Changes

  • Since we have many types of pages now (.astro, .md, .mdx, .html), this plugin consolidates logic around the injectScript hook for page-ssr into a single place
  • This also consolidates the injectScript hook for page into the rendering step during dev. It is already handled in build.

Testing

Covered by existing tests

Docs

N/A, refactor

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2022

🦋 Changeset detected

Latest commit: 7f09eee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
astro Patch
@astrojs/mdx Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 26, 2022
@natemoo-re natemoo-re marked this pull request as ready for review August 1, 2022 20:26
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 1, 2022
@natemoo-re natemoo-re merged commit b60cc05 into main Aug 2, 2022
@natemoo-re natemoo-re deleted the feat/generic-page-plugin branch August 2, 2022 19:07
@astrobot-houston astrobot-houston mentioned this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants