Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: reintroduce smoke tests across example projects #3669

Merged
merged 20 commits into from
Jul 12, 2022

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Jun 21, 2022

Changes

  • Remove no-frozen requirement from lockfile
  • Remove astro.build and Astro docs installation. Still checking out via CI, will revisit in a future PR
  • Add smoke test across example projects
  • Remove client: directive from with-mdx example. This is causing an infinite build loop to debug separately
  • Remove @astrojs/markdown-remark/ssr-utils that our generated markdown files directly imported. This caused a missing dependency issue since @astrojs/markdown isn't explicitly installed.

Testing

Testing CI

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2022

🦋 Changeset detected

Latest commit: 568aa72

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
astro Patch
@astrojs/markdown-remark Patch
@e2e/astro-component Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthewp
Copy link
Contributor

👍

@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Jun 21, 2022
@natemoo-re
Copy link
Member Author

Gotta call it for the day. Left some notes in Discord in the #dev channel.

@matthewp
Copy link
Contributor

I merged #3674 which reverted the change that broke CI. Can continue fixing the smoke tests here.

@natemoo-re natemoo-re force-pushed the chore/remove-smoke-from-lockfile branch 2 times, most recently from 897df5f to a095e28 Compare June 28, 2022 13:40
@natemoo-re natemoo-re force-pushed the chore/remove-smoke-from-lockfile branch from a095e28 to 340227a Compare June 30, 2022 21:28
@natemoo-re
Copy link
Member Author

@bholmesdev is picking this one up! We're hoping to build the @examples/* first, then we should follow-up with better withastro/docs and withastro/astro.build coverage

@bholmesdev bholmesdev force-pushed the chore/remove-smoke-from-lockfile branch from 9a988fe to fd2d14f Compare July 11, 2022 21:10
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jul 11, 2022
@bholmesdev bholmesdev force-pushed the chore/remove-smoke-from-lockfile branch from 15deef3 to 44eb5c1 Compare July 11, 2022 21:20
@github-actions github-actions bot removed the pkg: integration Related to any renderer integration (scope) label Jul 11, 2022
@bholmesdev bholmesdev force-pushed the chore/remove-smoke-from-lockfile branch from 7d4d67a to e772a39 Compare July 11, 2022 21:32
@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 11, 2022
@github-actions github-actions bot added the feat: markdown Related to Markdown (scope) label Jul 11, 2022
@@ -161,12 +161,16 @@ export default function markdown({ config }: AstroPluginOptions): Plugin {
const { layout = '', components = '', setup = '', ...content } = frontmatter;
content.astro = metadata;
const prelude = `---
import { slug as $$slug } from '@astrojs/markdown-remark/ssr-utils';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove direct import from @astrojs/markdown-remark sub-dependency. Since this isn't explicitly installed, astro build will fail from our monorepo

@bholmesdev bholmesdev marked this pull request as ready for review July 11, 2022 22:59
@bholmesdev bholmesdev changed the title chore: remove smoke/astro.build from lockfile Fix: reintroduce smoke tests across example projects Jul 11, 2022
@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Jul 11, 2022
@@ -14,4 +14,4 @@ Written by: {new Intl.ListFormat('en').format(authors.map(d => d.name))}.

Published on: {new Intl.DateTimeFormat('en', {dateStyle: 'long'}).format(published)}.

<Counter client:idle>## This is a counter!</Counter>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove client: directive. This is causing an infinite build loop that our smoke test (thankfully!) picked up

@@ -180,16 +180,21 @@ jobs:
needs: build
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tests are mysteriously failing on windows-latest. We'll need to investigate separately

Copy link
Member Author

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the docs team likes to say, NWTWWHB!

Can't approve my own PR but LGTM.

@bholmesdev bholmesdev merged commit 93e1020 into main Jul 12, 2022
@bholmesdev bholmesdev deleted the chore/remove-smoke-from-lockfile branch July 12, 2022 02:51
@astrobot-houston astrobot-houston mentioned this pull request Jul 12, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* chore: update smoke tests

* chore: bump smoke tests to node@16

* chore: remove gitmodules

* chore(ci): prefer node@14

* wip: remove path from smoke clone step

* feat: run build:examples from test:smoke

* fix: remove no-frozen-lockfile

* fix: checkout monorepo last for pnpm setup

* wip: replace @astrojs/markdown/remark import from md

* fix: remove type defs from generated file

* fix: function order

* chore: remove ssr-utils export

* wip: remove windows from smoke test

* fix: instantiate slugger in snippet

* fix: exclude with-mdx from smoke (for now)

* fix: add quotes on filter flag for safety

* chore: changeset

* wip: try reintroducing windows smoke

* sad chore: remove client: directive from with-mdx

* Revert "wip: try reintroducing windows smoke"

This reverts commit 9529b1a.

Co-authored-by: Nate Moore <nate@astro.build>
Co-authored-by: bholmesdev <hey@bholmes.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 action Modifies GitHub Actions feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants