Fix: reintroduce smoke tests across example projects #3669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 568aa72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👍 |
|
Gotta call it for the day. Left some notes in Discord in the |
|
I merged #3674 which reverted the change that broke CI. Can continue fixing the smoke tests here. |
natemoo-re
force-pushed
the
chore/remove-smoke-from-lockfile
branch
2 times, most recently
from
897df5f
to
a095e28
Compare
natemoo-re
force-pushed
the
chore/remove-smoke-from-lockfile
branch
from
a095e28
to
340227a
Compare
|
@bholmesdev is picking this one up! We're hoping to build the |
bholmesdev
force-pushed
the
chore/remove-smoke-from-lockfile
branch
from
9a988fe
to
fd2d14f
Compare
github-actions
bot
added
the
pkg: integration
bholmesdev
force-pushed
the
chore/remove-smoke-from-lockfile
branch
from
15deef3
to
44eb5c1
Compare
github-actions
bot
removed
the
pkg: integration
bholmesdev
force-pushed
the
chore/remove-smoke-from-lockfile
branch
from
7d4d67a
to
e772a39
Compare
github-actions
bot
added
the
pkg: astro
bholmesdev
reviewed
Jul 11, 2022
| @@ -161,12 +161,16 @@ export default function markdown({ config }: AstroPluginOptions): Plugin { | |||
| const { layout = '', components = '', setup = '', ...content } = frontmatter; | |||
| content.astro = metadata; | |||
| const prelude = `--- | |||
| import { slug as $$slug } from '@astrojs/markdown-remark/ssr-utils'; | |||
There was a problem hiding this comment.
Remove direct import from @astrojs/markdown-remark sub-dependency. Since this isn't explicitly installed, astro build will fail from our monorepo
bholmesdev
changed the title
This reverts commit 9529b1a.
bholmesdev
reviewed
Jul 11, 2022
| @@ -14,4 +14,4 @@ Written by: {new Intl.ListFormat('en').format(authors.map(d => d.name))}. | |||
|
|
|||
| Published on: {new Intl.DateTimeFormat('en', {dateStyle: 'long'}).format(published)}. | |||
|
|
|||
| <Counter client:idle>## This is a counter!</Counter> | |||
There was a problem hiding this comment.
Remove client: directive. This is causing an infinite build loop that our smoke test (thankfully!) picked up
bholmesdev
reviewed
Jul 11, 2022
| @@ -180,16 +180,21 @@ jobs: | |||
| needs: build | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-latest, windows-latest] | |||
There was a problem hiding this comment.
Smoke tests are mysteriously failing on windows-latest. We'll need to investigate separately
natemoo-re
commented
Jul 12, 2022
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* chore: update smoke tests * chore: bump smoke tests to node@16 * chore: remove gitmodules * chore(ci): prefer node@14 * wip: remove path from smoke clone step * feat: run build:examples from test:smoke * fix: remove no-frozen-lockfile * fix: checkout monorepo last for pnpm setup * wip: replace @astrojs/markdown/remark import from md * fix: remove type defs from generated file * fix: function order * chore: remove ssr-utils export * wip: remove windows from smoke test * fix: instantiate slugger in snippet * fix: exclude with-mdx from smoke (for now) * fix: add quotes on filter flag for safety * chore: changeset * wip: try reintroducing windows smoke * sad chore: remove client: directive from with-mdx * Revert "wip: try reintroducing windows smoke" This reverts commit 9529b1a. Co-authored-by: Nate Moore <nate@astro.build> Co-authored-by: bholmesdev <hey@bholmes.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
no-frozenrequirement from lockfileastro.buildand Astro docs installation. Still checking out via CI, will revisit in a future PRclient:directive fromwith-mdxexample. This is causing an infinite build loop to debug separately@astrojs/markdown-remark/ssr-utilsthat our generated markdown files directly imported. This caused a missing dependency issue since@astrojs/markdownisn't explicitly installed.Testing
Testing CI
Docs
N/A