feat: add SSR adaptor for cloudflare pages functions #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 699382c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
nrgnrg
force-pushed
the
feat/pages-functions-adaptor
branch
from
5ae8ea4 to
e94044c
Compare
natemoo-re
requested changes
Jun 15, 2022
There was a problem hiding this comment.
Hey @nrgnrg! This is great work, just one note on the change to serializeProps. Probably not necessary anymore. 😉
nrgnrg
force-pushed
the
feat/pages-functions-adaptor
branch
from
e94044c to
699382c
Compare
github-actions
bot
removed
the
pkg: astro
|
@natemoo-re I've removed the |
natemoo-re
approved these changes
Jun 15, 2022
matthewp
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Notes
There is 1 change within the Astro server runtime which was necessary to make this work,'serialize-javascript'generates a random number at the top level of the module, this is a pattern which is forbidden by Cloudflare workers. The error given is this:The fix is dynamically importing the dependency so that it generates the random number at call time, even when inlined in the build.Testing
Docs