Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Netlify adapter and dynamic routes #3011

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Apr 6, 2022

Changes

  • Adds dynamic routes to the special _redirects file.
  • Makes Astro export a RoutePart interface that is used by the file-based router to parse dynamic route paths. This is used by the integration.

Testing

  • Added a test for the adapter.

Docs

N/A, bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2022

🦋 Changeset detected

Latest commit: 8e5b83f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
astro Patch
@astrojs/netlify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) test labels Apr 6, 2022
@matthewp matthewp self-assigned this Apr 6, 2022
Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass!

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@matthewp matthewp merged commit c6f8bce into main Apr 6, 2022
@matthewp matthewp deleted the netlify-dynamic-routes branch April 6, 2022 20:21
This was referenced Apr 6, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Fix Netlify adapter and dynamic routes

* Changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants