Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing format command in CI #2696

Merged
merged 4 commits into from
Mar 1, 2022
Merged

fix failing format command in CI #2696

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
870682f
fix failing format command in CI
FredKSchott Mar 1, 2022
89c09b7
adds a check to formatting to ci
FredKSchott Mar 1, 2022
0b1f816
ignore the prettier plugin for now
FredKSchott Mar 1, 2022
9295322
update smoke to remove prettier plugin
FredKSchott Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adds a check to formatting to ci
  • Loading branch information
@FredKSchott
FredKSchott committed Mar 1, 2022
commit 89c09b729c86368ef4bdf3452cfb3e14828c6c8b
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@ jobs:
github_token: ${{ secrets.GITHUB_TOKEN }}
neutral_check_on_warning: true

# Checks that the formatter runs successfully on all files
# In the future, we may have this fail PRs on unformatted code
- name: Format Check
run: yarn format --list

# Build installs all devDependencies and runs our full build pipeline.
# We upload all `dist/` artifacts to GitHub, which can be shared by all dependent jobs.
build:
Expand Down