feat(node)!: remove experimentalErrorPageHost#15654
Open
florian-lefebvre wants to merge 1 commit intomainfrom
Open
feat(node)!: remove experimentalErrorPageHost#15654florian-lefebvre wants to merge 1 commit intomainfrom
florian-lefebvre wants to merge 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: a46d7ee The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
sarah11918
reviewed
Feb 25, 2026
Member
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Thanks Florian! Just a couple thoughts from me!
|
|
||
| Removes the `experimentalErrorPageHost` option | ||
|
|
||
| This option allowed to fetch the prerendered error page from a different host than the server it's currently running on. |
Member
There was a problem hiding this comment.
Suggested change
| This option allowed to fetch the prerendered error page from a different host than the server it's currently running on. | |
| This option allowed fetching a prerendered error page from a different host than the server is currently running on. |
|
|
||
| This option allowed to fetch the prerendered error page from a different host than the server it's currently running on. | ||
|
|
||
| However, we found it very hard to make it secure so we decided to remove it. You can replicate the old behavior by runninng with `mode: 'middleware'` and intercepting responses. |
Member
There was a problem hiding this comment.
Suggested change
| However, we found it very hard to make it secure so we decided to remove it. You can replicate the old behavior by runninng with `mode: 'middleware'` and intercepting responses. | |
| However, there can be security implications with prefetching from other hosts, and often more customization was required to do this safely. This has now been removed as a built-in option so that you can implement your own secure solution as needed and appropriate for your project via middleware. | |
| #### What should I do? | |
| If you were previously using this feature, you must remove the option from your adapter configuration as it no longer exists. You can replicate the previous behavior by running with `mode: 'middleware'` and intercepting responses. |
Maybe something like this? I would also show the node config with a diff and - this line. If it's easy (and short!) enough to show a brief generic code example of intercepting a response, I think it could be handy, too. (If it's not, then I wouldn't bother. But I'd still show removing from the config!)
ematipico
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Improves our tests to still check we read files from the filesystem
Docs