refactor: removes support of Shiki with CSP#15640
Merged
Conversation
github-actions
bot
added
feat: markdown
🦋 Changeset detectedLatest commit: 16f3c24 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewp
approved these changes
Feb 24, 2026
sarah11918
approved these changes
Feb 24, 2026
Member
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Approving for docs (changeset and warning message)!
yanthomasdev
approved these changes
Feb 24, 2026
This reverts commit 84d6efd.
ematipico
force-pushed
the
fix/code-regressions
branch
from
ff833d6 to
16f3c24
Compare
rururux
reviewed
Feb 24, 2026
| @@ -1,15 +1,10 @@ | |||
| --- | |||
| import { createShikiHighlighter, type ThemePresets } from '@astrojs/markdown-remark/shiki'; | |||
Contributor
There was a problem hiding this comment.
Sorry for the late catch after the merge, but if we revert this part as well, won't it cause the Cloudflare Workers error to resurface?
Contributor
There was a problem hiding this comment.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Closes #15608
Closes #15582
Revert #15582
Unfortunately we can't, in any way possible, to support Shiki with CSP. After extensive research, and realised that I broke things with my previous PR, we can't have a solution that works for everything.
Even with head propagation, markdown files can't be supported.
I added a warning for our users
Testing
CI is green
Docs
withastro/docs#13307
/cc @withastro/maintainers-docs for feedback!