feat: add new experimental Rust compiler#15543
Conversation
🦋 Changeset detectedLatest commit: 1255d5f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
left a comment
There was a problem hiding this comment.
I can't see where tests are updated. I don't see tests that use the new experimental flag
There are no tests using the flag, I just updated them so that they can run in local. I can add a test using it, I guess |
|
Yes please, I would like to see some tests. Especially the error around unclosed tags, which is part of the expectations of the new compiler |
sarah11918
left a comment
There was a problem hiding this comment.
RUST. RUST. RUST. Incrabible work, @Princesseuh !
Just a sample of what I think we could add to the changeset that I think is helpful!
| */ | ||
| svgo?: boolean | SvgoConfig; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Noting that it's expected that there's no @docs tag here for an experimental feature! Everything is documented on the experimental docs page!
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
sarah11918
left a comment
There was a problem hiding this comment.
Approved by me! Ready for @yanthomasdev !
yanthomasdev
left a comment
There was a problem hiding this comment.
Looks good to me, just two small nits and we are done! 🦀
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Changes
Adds a new experimental flag to use the Rust compiler instead of the Go one. This requires users to install @astrojs/compiler-rs in their project manually.
Testing
I edited some tests so that they pass on both the old and the new compiler:
Apart from that, I believe that all tests pass on both compilers.
Docs
There's a JSDoc and withastro/docs#13303