Add appEntrypoint to @astrojs/react to enable users to wrap every React island with a custom component#15368
Open
meyer wants to merge 1 commit intowithastro:mainfrom
Open
Add appEntrypoint to @astrojs/react to enable users to wrap every React island with a custom component#15368meyer wants to merge 1 commit intowithastro:mainfrom
appEntrypoint to @astrojs/react to enable users to wrap every React island with a custom component#15368meyer wants to merge 1 commit intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 7783a6c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes |
216c185 to
b344880
Compare
appEntrypoint feature to @astrojs/react as wellappEntrypoint to @astrojs/react, pass locals to render context
appEntrypoint to @astrojs/react, pass locals to render contextappEntrypoint to @astrojs/react, pass locals to renderer context
b344880 to
7783a6c
Compare
Contributor
|
Thanks! We're going to discuss this internally and then will get back to you. |
appEntrypoint to @astrojs/react, pass locals to renderer contextappEntrypoint to @astrojs/react, pass locals to render context
appEntrypoint to @astrojs/react, pass locals to render contextappEntrypoint to @astrojs/react to enable users to wrap every React island with a custom component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
@astrojs/react,appEntrypoint. It looks a whole lot like the Vue integration’s appEntrypoint option and it functions nearly identically. Specify a path to a file that has a default-exported component and that component will be used to wrap every React island.I addedRemoved for now but you can see the change here (it’s pretty minimal)Astro.localsto the render context and am passingAstro.localsthrough toappEntrypoint’s component as a prop calledlocals. The prop is only set in a server environment; clientside it’s justundefined.Testing
New tests added that cover
appEntrypointin generalas well as the.localspropDocs
PR with docs update is here: withastro/docs#13208