Replace internal cssScopeTo implementation to vite.cssScopeTo#13668
Merged
ematipico merged 6 commits intowithastro:mainfrom May 14, 2025
Merged
Replace internal cssScopeTo implementation to vite.cssScopeTo#13668ematipico merged 6 commits intowithastro:mainfrom
ematipico merged 6 commits intowithastro:mainfrom
Conversation
Co-authored-by: bluwy <bjornlu.dev@gmail.com>
🦋 Changeset detectedLatest commit: 08373b6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: svelte
ematipico
added
the
pr preview
astro
@astrojs/cloudflare
@astrojs/netlify
@astrojs/node
@astrojs/vercel
commit: |
CodSpeed Performance ReportMerging #13668 will not alter performanceComparing Summary
|
Member
|
I just tested this on the Biome website, and I couldn't find any regressions |
github-actions
bot
removed
pkg: svelte
Contributor
Author
|
I've resolved the conflicts. |
Member
|
@sapphi-red can you please provide a changeset? Even if it's an internal change, we want to track it so if there are some regressions, there's a changelog line that refers to it. A |
Contributor
Author
|
Done 👍 |
ematipico
approved these changes
May 14, 2025
Merged
ematipico
added a commit
that referenced
this pull request
May 16, 2025
Co-authored-by: bluwy <bjornlu.dev@gmail.com> Co-authored-by: ematipico <602478+ematipico@users.noreply.github.com>
openscript
pushed a commit
to openscript/astro
that referenced
this pull request
Sep 12, 2025
…tro#13668) Co-authored-by: bluwy <bjornlu.dev@gmail.com> Co-authored-by: ematipico <602478+ematipico@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Upgrades Vite to 6.3 that includes the revised version of
cssScopeTo(vitejs/vite#19678) that aligns with astro'scssScopeToimplementation and reapplies #13347.Testing
Existing tests should pass. There's added test in the past from #10291. If CI fails, maybe there's a bug in Vite.
Docs
N/A Shouldn't require a changeset as it's an internal refactor (the changeset for upgrading Vite is included).