fix(astro): stop toolbar settings from overflowing#13383
Merged
ascorbic merged 1 commit intowithastro:mainfrom May 21, 2025
Merged
fix(astro): stop toolbar settings from overflowing#13383ascorbic merged 1 commit intowithastro:mainfrom
ascorbic merged 1 commit intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 88bd907 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
667dcaa to
88bd907
Compare
CodSpeed Performance ReportMerging #13383 will not alter performanceComparing Summary
|
astro
@astrojs/cloudflare
@astrojs/netlify
@astrojs/node
@astrojs/vercel
commit: |
Merged
openscript
pushed a commit
to openscript/astro
that referenced
this pull request
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The problem was the the content of the toolbar settings overflowed the toolbar. That made it very hard to read the text it looked broken.
I did a few things:
Before
After
Bildschirmaufnahme.2025-03-09.um.12.35.04.mov
Testing
I did some manual testing, by resizing the window and testing the changes on a real iPhone. I did not any automated tests, because there's now way to test this without a visual test. Please correct me if I'm wrong.
Docs
This change does not need documentation, it doesn't change how users
need to interact with Astro.