Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle pathname for dynamic routing in rewrite #13113

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

unprintable123
Copy link
Contributor

Changes

rewrite will first decode pathname before passing it to dynamic routing.

Fixes #13098

Testing

Add test cases for dynamic routing. Only static mode rewrite is tested.

Docs

Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: 1895db5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 31, 2025
Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #13113 will not alter performance

Comparing unprintable123:patch-1 (1895db5) with main (23978dd)

Summary

✅ 6 untouched benchmarks

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix! Thank you for your contribution @unprintable123

@ematipico ematipico merged commit 3a26e45 into withastro:main Jan 31, 2025
17 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astro.rewrite encodes path into url causes dynamic params mismatch
2 participants