Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples for v5 #12588

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Update examples for v5 #12588

merged 5 commits into from
Dec 3, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Dec 2, 2024

Changes

Testing

Tested the changed examples locally and existing tests should still pass.

Docs

No docs, we have enough v5 docs I think! 😁

Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: 06e7209

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@delucis delucis changed the title Update example for v5 Update examples for v5 Dec 2, 2024
@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Dec 2, 2024
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 We can merge this now if we want as it won't sync to stable immediately as we have changesets queued up. Once we cut a new release then it'll sync these examples again.

@delucis delucis merged commit 3a144b1 into main Dec 3, 2024
15 checks passed
@delucis delucis deleted the chris/v5-examples branch December 3, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants