fix: astrodb vite plugin throws in vitest and cannot seed database

[haivuw]

Changes

Fixes #11414

import.meta.env is undefined in the virtual module which make it throw and the database is not seeded.

Testing

Tested by linking local @astrojs/db in my other project. Db was seeded ok.

Docs

just a minor bug fix

[changeset-bot]

🦋 Changeset detected

Latest commit: 905562c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[haivuw]

I couldn't run all tests #11441. Though @astrojs/db:test alone passed.

[marpe]

Just ran into this issue, would be nice to have this merged.

[matthewp]

@haivuw can you update this PR

[haivuw]

@matthewp I resolved the conflicts but this test failed on Windows:
https://github.com/withastro/astro/blob/ff522b96a01391a29b44f820dfcc2a2176d871e7/packages/db/test/local-prod.test.js#L37C3-L37C4

The path to local db is malformed: /D:/a/astro/astro/packages/db/testixtures�asicsdistastro.db

✖ failing tests:

test at file:\D:\a\astro\astro\packages\db\test\local-prod.test.js:50:3
✖ Can render page
  'test did not finish before its parent and was cancelled'

test at file:\D:\a\astro\astro\packages\db\test\local-prod.test.js:37:2
✖ build (not remote) with DATABASE_FILE env (relative file path) (683.227ms)
  [astro:db] Could not load astro:db (imported by test/fixtures/local-prod/src/pages/index.astro): Failed to connect to database: `Unable to open connection to local database /D:/a/astro/astro/packages/db/testixtures�asicsdistastro.db: 14`
  Error: Failed to connect to database: `Unable to open connection to local database /D:/a/astro/astro/packages/db/testixtures�asicsdistastro.db: 14`
      at new Database (D:\a\astro\astro\node_modules\.pnpm\libsql@0.4.5\node_modules\libsql\index.js:83:17)
      at _createClient (file:///D:/a/astro/astro/node_modules/.pnpm/@libsql+client@0.14.0/node_modules/@libsql/client/lib-esm/sqlite3.js:47:16)
      at _createClient (file:///D:/a/astro/astro/node_modules/.pnpm/@libsql+client@0.14.0/node_modules/@libsql/client/lib-esm/node.js:21:16)
      at Module.createClient (file:///D:/a/astro/astro/node_modules/.pnpm/@libsql+client@0.14.0/node_modules/@libsql/client/lib-esm/node.js:11:12)
      at Module.createLocalDatabaseClient (D:/a/astro/astro/packages/db/dist/runtime/db-client.js:25:40)
      at eval (astro:db:seed:8:34)
      at async instantiateModule (file:///D:/a/astro/astro/node_modules/.pnpm/vite@5.4.9_@types+node@18.19.50_sass@1.79.5/node_modules/vite/dist/node/chunks/dep-Cyk9bIUq.js:52961:5) {
    code: 'PLUGIN_ERROR',
    pluginCode: '',
    plugin: 'astro:db',
    hook: 'load',

I don't have the capacity to make sure all tests pass right now. So this is as far as I can do.

[ematipico]

I don't think you need to stringify the string, because it's already a string. We already to such here:

astro/packages/db/src/core/integration/vite-plugin-db.ts

Lines 211 to 212 in ff522b9

	const { ASTRO_DATABASE_FILE } = getAstroEnv();
	const dbUrl = normalizeDatabaseUrl(ASTRO_DATABASE_FILE, new URL(DB_PATH, root).href);

[haivuw]

It will be

const dbUrl = normalizeDatabaseUrl(file://local.db, ${JSON.stringify(dbUrl)});

without stringification.

But I just realized I could have used JSON.stringify, so I'll update.

[ematipico]

I see. The failing test is definitely weird though, I wonder what's causing the failure

[haivuw]

I think the test passed before because ASTRO_DATABASE_URL was not passed to the plugin at all.

And this line of the test generates a malformed path on Windows:

astro/packages/db/test/local-prod.test.js

Line 39 in ff522b9

const prodDbPath = relative(process.cwd(), fileURLToPath(absoluteFileUrl));

which is /D:/a/astro/astro/packages/db/testixtures�asicsdistastro.db

[haivuw]

Hopefully someone with Windows machine can fix that.

[haivuw]

Wait it passed now 💀

[haivuw]

I'm not sure what magic JSON.stringify does here.