Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(astro): address astro env rfc feedback #11213

Merged
merged 17 commits into from
Jun 11, 2024

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Jun 8, 2024

Todo

  • Update fixtures
    • remove prefix
    • check getSecret usage
  • Update documentation
  • changesets
    • public
    • secrets

Changes

  • Removes the PUBLIC_ prefix constraint
  • Allows importing secrets from astro:env/server directly

Testing

Tests should still pass

Docs

Config reference updated

Copy link

changeset-bot bot commented Jun 8, 2024

🦋 Changeset detected

Latest commit: 0d96625

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 8, 2024
@github-actions github-actions bot added the pr: docs A PR that includes documentation for review label Jun 10, 2024
@florian-lefebvre florian-lefebvre marked this pull request as ready for review June 10, 2024 15:27
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, @florian-lefebvre ! 🫡

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci @florian-lefebvre !

Left some tiny comments below!

.changeset/dirty-rabbits-act.md Outdated Show resolved Hide resolved
.changeset/clever-jars-trade.md Show resolved Hide resolved
.changeset/dirty-rabbits-act.md Outdated Show resolved Hide resolved
.changeset/dirty-rabbits-act.md Outdated Show resolved Hide resolved
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
.changeset/dirty-rabbits-act.md Outdated Show resolved Hide resolved
.changeset/dirty-rabbits-act.md Outdated Show resolved Hide resolved
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs!! 🥳

@florian-lefebvre florian-lefebvre merged commit 94ac7ef into main Jun 11, 2024
14 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/astro-env-rfc-feedback branch June 11, 2024 18:17
@astrobot-houston astrobot-houston mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants