Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade pnpm #11146

Merged
merged 3 commits into from
Jun 11, 2024
Merged

feat: upgrade pnpm #11146

merged 3 commits into from
Jun 11, 2024

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented May 25, 2024

Changes

Testing

Tests should still pass. Smoke tests are failing because docs pnpm version need to match (withastro/docs#8394)

Docs

N/A, no changeset

Copy link

changeset-bot bot commented May 25, 2024

⚠️ No Changeset found

Latest commit: 2bd2cc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 25, 2024
@florian-lefebvre florian-lefebvre marked this pull request as ready for review May 25, 2024 11:38
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the big change with pnpm v9 is that it will validate packageManager matching your current running pnpm version before executing, and error if not matching. This means everyone working on this monorepo should be using corepack.

I'd probably like to hear thoughts on this if this affects anyone. Otherwise we can disable this restriction with https://pnpm.io/npmrc#engine-strict. I heard corepack can be tricky to use if you use pnpm to manage Node.js versions.

Also, we should update CONTRIBUTING.md about the latest pnpm version. There's a lot of logistics when upgrading pnpm hence why I disabled it in renovate 😅

packages/astro/package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the pkg: astro Related to the core `astro` package (scope) label May 27, 2024
@florian-lefebvre
Copy link
Member Author

Should we recommend corepack in CONTRIBUTING.md?

@bluwy
Copy link
Member

bluwy commented May 27, 2024

I'm ok with recommending corepack, and even requiring it if others are fine with it.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about this. LGTM

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's 🐑 it

@florian-lefebvre florian-lefebvre merged commit 02e5617 into main Jun 11, 2024
17 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/upgrade-pnpm branch June 11, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo can't be opened on GitHub codespaces
3 participants