-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade pnpm #11146
feat: upgrade pnpm #11146
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the big change with pnpm v9 is that it will validate packageManager
matching your current running pnpm version before executing, and error if not matching. This means everyone working on this monorepo should be using corepack.
I'd probably like to hear thoughts on this if this affects anyone. Otherwise we can disable this restriction with https://pnpm.io/npmrc#engine-strict. I heard corepack can be tricky to use if you use pnpm to manage Node.js versions.
Also, we should update CONTRIBUTING.md
about the latest pnpm version. There's a lot of logistics when upgrading pnpm hence why I disabled it in renovate 😅
Should we recommend corepack in |
I'm ok with recommending corepack, and even requiring it if others are fine with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot about this. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's 🐑 it
Changes
Testing
Tests should still pass. Smoke tests are failing because docs pnpm version need to match (withastro/docs#8394)
Docs
N/A, no changeset