-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent importing db core from db runtime #10568
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@astrojs/db": patch | ||
--- | ||
|
||
Prevent runtime from importing core code |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import { bold, red } from 'kleur/colors'; | ||
|
||
export const FOREIGN_KEY_DNE_ERROR = (tableName: string) => { | ||
return `Table ${bold( | ||
tableName | ||
)} references a table that does not exist. Did you apply the referenced table to the \`tables\` object in your db config?`; | ||
}; | ||
|
||
export const FOREIGN_KEY_REFERENCES_LENGTH_ERROR = (tableName: string) => { | ||
return `Foreign key on ${bold( | ||
tableName | ||
)} is misconfigured. \`columns\` and \`references\` must be the same length.`; | ||
}; | ||
|
||
export const FOREIGN_KEY_REFERENCES_EMPTY_ERROR = (tableName: string) => { | ||
return `Foreign key on ${bold( | ||
tableName | ||
)} is misconfigured. \`references\` array cannot be empty.`; | ||
}; | ||
|
||
export const REFERENCE_DNE_ERROR = (columnName: string) => { | ||
return `Column ${bold( | ||
columnName | ||
)} references a table that does not exist. Did you apply the referenced table to the \`tables\` object in your db config?`; | ||
}; | ||
|
||
export const SEED_ERROR = (error: string) => { | ||
return `${red(`Error while seeding database:`)}\n\n${error}`; | ||
}; | ||
|
||
export const SEED_DEFAULT_EXPORT_ERROR = (fileName: string) => { | ||
return SEED_ERROR(`Missing default function export in ${bold(fileName)}`); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: maybe we can move
errors.ts
to the base of thesrc
directory instead of splitting into two modules?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely can, it's interesting though that none of the errors are shared between. in which case, why have them together?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, honestly expected at least one to be shared. Guess we can keep separate if that's the case!