Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing embedding appToken from CI #10497

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Removing embedding appToken from CI #10497

merged 1 commit into from
Mar 19, 2024

Conversation

matthewp
Copy link
Contributor

Changes

  • Removes fallbacks that grab the app token from the CI env.
  • This is because we require this token be set in your host env instead.

Testing

N/A

Docs

N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2024

🦋 Changeset detected

Latest commit: c1147f7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

bholmesdev
bholmesdev approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd do a sanity check that a Vercel deploy sets the secret correctly. If it works, take this approval as a token of my appreciation

@matthewp matthewp merged commit 2fc7231 into main Mar 19, 2024
13 checks passed
@matthewp matthewp deleted the remove-env2 branch March 19, 2024 18:48
@astrobot-houston astrobot-houston mentioned this pull request Mar 19, 2024
Merged
matthewp added a commit that referenced this pull request Mar 21, 2024
@matthewp
Revert "Removing embedding appToken from CI (#10497)"
2021f73 
This reverts commit 2fc7231.
matthewp added a commit that referenced this pull request Mar 21, 2024
@matthewp
Revert "Removing embedding appToken from CI (#10497)" (#10520)
30ce9a0 
* Revert "Removing embedding appToken from CI (#10497)"

This reverts commit 2fc7231.

* Changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bholmesdev bholmesdev bholmesdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewp @bholmesdev