Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mdx test fail with rehype-pretty-code #10370

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Fix mdx test fail with rehype-pretty-code #10370

merged 1 commit into from
Mar 8, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Mar 8, 2024

Changes

We're using shiki 1.0, and rehype-pretty-code has a peer dep on shiki, so we also need to bump rehype-pretty-code to latest so it supports shiki 1.0. This is not a breaking change for Astro since existing users of rehype-pretty-code can install shiki 0.x locally to continue have it work.

Testing

Ran the mdx tests locally.

Docs

n/a

Copy link

changeset-bot bot commented Mar 8, 2024

⚠️ No Changeset found

Latest commit: bf74570

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Mar 8, 2024
@bluwy bluwy merged commit 9e1ef6f into main Mar 8, 2024
11 of 13 checks passed
@bluwy bluwy deleted the fix-mdx-fail branch March 8, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants