Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): remove params for prerendered pages #10199

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Feb 22, 2024

Changes

Testing

Added a unit test

Docs

Does not affect usage.

Copy link

changeset-bot bot commented Feb 22, 2024

🦋 Changeset detected

Latest commit: 43204d6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 22, 2024
Comment on lines +40 to +43
// HACK! astro:assets uses query params for the injected route in `dev`
if (removeParams && url.pathname !== '/_image') {
url.search = '';
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😔 I know it's not new code, but still hate it, ha.

@lilnasy lilnasy merged commit 6aa660a into withastro:main Feb 23, 2024
13 checks passed
@lilnasy lilnasy deleted the fix/9440 branch February 23, 2024 15:26
@astrobot-houston astrobot-houston mentioned this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query Params Shouldn't Be Accessible in Pre-rendered Pages During Development
3 participants