fix: better assetsInlineLimit runtime type checking

.changeset/late-bears-collect.md

@@ -0,0 +1,5 @@
+---
+"astro": patch
+---
+
+Fixes a minor regression from 4.3.x when the vite.build.assetsInlineLimit configuration option was set to a string. Astro now automatically casts this to a number to match the Vite behaviour.

packages/astro/src/core/build/plugins/util.ts

@@ -75,8 +75,8 @@ export function shouldInlineAsset(
 	assetPath: string,
 	assetsInlineLimit: NonNullable<BuildOptions['assetsInlineLimit']>
 ) {
-	if (typeof assetsInlineLimit === 'number') {
-		return Buffer.byteLength(assetContent) < assetsInlineLimit;
+	if (typeof assetsInlineLimit === 'number' || typeof assetsInlineLimit === 'string') {
+		return Buffer.byteLength(assetContent) < Number(assetsInlineLimit);
 	}
 
 	const result = assetsInlineLimit(assetPath, Buffer.from(assetContent));

packages/astro/test/css-assets.test.js

@@ -48,3 +48,49 @@ describe('Assets in CSS', () => {
 		assert.equal(getAllMatches(/font-face/g, css), 1);
 	});
 });
+
+describe('Assets in CSS - string assetsInlineLimit', () => {
+	let fixture;
+
+	before(async () => {
+		fixture = await loadFixture({
+			root: './fixtures/css-assets/',
+			vite: {
+				build: {
+					assetsInlineLimit: '0',
+				},
+			},
+		});
+		await fixture.build();
+	});
+
+	function getAllMatches(re, text) {
+		let count = 0;
+		while (re.exec(text) !== null) {
+			++count;
+		}
+		return count;
+	}
+
+	async function getCSSForPage(pathname) {
+		const html = await fixture.readFile(pathname);
+		const $ = cheerio.load(html);
+		const cssPath = $('link').attr('href');
+		const css = await fixture.readFile(cssPath);
+		return css;
+	}
+
+	it('Bundled CSS does not have __VITE_ASSET__', async () => {
+		let css = await getCSSForPage('/one/index.html');
+		assert.equal(css.includes('__VITE_ASSET__'), false);
+		css = await getCSSForPage('/two/index.html');
+		assert.equal(css.includes('__VITE_ASSET__'), false);
+	});
+
+	it('Pages contain only their own CSS', async () => {
+		let css = await getCSSForPage('/one/index.html');
+		assert.equal(getAllMatches(/font-face/g, css), 1);
+		css = await getCSSForPage('/two/index.html');
+		assert.equal(getAllMatches(/font-face/g, css), 1);
+	});
+});