-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to shiki and stabilize dual themes support #10130
Conversation
🦋 Changeset detectedLatest commit: 4bdd901 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
QQ: Wouldn't it make sense to add functionality such as decorators to the |
I guess we could too, along with transformers which is already supported in |
That'd be awesome! |
@bluwy @ematipico Can you fix conflicts and merge them into master? I can't wait to use the new Shiki :) |
I can fix them up later today, but this will only be merged for the next minor, which is scheduled some time next week. There shouldn't be any significant changes on the user-side though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this (and the accompanying docs PR) for docs!
Changes
shikiji
has been merged intoshiki
1.0. This PR also moves back toshiki
. There weren't any significant changes, so this PR is mainly package name change and small compat code added.markdown.shikiConfig.experimentalThemes
is also stabilized asmarkdown.shikiConfig.themes
together with the move toshiki
. It is not considered experimental byshikiji
orshiki
anymore.Testing
Existing tests should pass
Docs
I've updated some links in the jsdoc to use the new site https://shiki.style. I've also made a docs PR: withastro/docs#6898