fix(i18n): regression where emitted URLs had //
#10067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5402a1b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
force-pushed
the
fix/regression-for-i18n-virtual-module
branch
from
7050e7a to
73d1e41
Compare
ematipico
changed the title
//
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
Feb 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes a bug where, under certain situations, the absolute URL emitted by the utility has a double slash.
I removed logic that wasn't needed and used the existing logic coming from
getRelativeLocaleUrl.Testing
I added a new unit test and used the
validateConfigfunction that emits the correct defaults from the Astro configuration. That's handy because I was struggling to get Astro defaults when running the unit tests. Ideally I could port all tests to use this pattern, and I'll do it in another PR.I also updated an integration test; for some reason, the configuration passed to that test wasn't updated. Regardless, the test case that I updated works as I wanted.
Docs