Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate vue related tests to node:test #10061

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

at-the-vr
Copy link
Member

@at-the-vr at-the-vr commented Feb 8, 2024

Changes

Testing

  • pnpm --filter astro run test:node
  • All tests passing

Docs

N/A

Copy link

changeset-bot bot commented Feb 8, 2024

⚠️ No Changeset found

Latest commit: 9e486a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 8, 2024
@at-the-vr at-the-vr changed the title chore: migrate slots-vue.test.js to node:test chore: migrate vue related tests to node:test Feb 8, 2024
@at-the-vr
Copy link
Member Author

should I break this into single file PRs like how its done so far? The test didn't broke when I kicked it off with the very 1st commit 53cc720 (#10061)

@bluwy
Copy link
Member

bluwy commented Feb 9, 2024

Create a single PR like this is fine. I'm currently checking out the CI fails, it's happening for other PRs too.

@bluwy
Copy link
Member

bluwy commented Feb 9, 2024

Actually, it looks like a real error that's causing it to fail:

  test at file:/Users/runner/work/astro/astro/packages/astro/test/vue-component.nodetest.js:51:2
  ✖ dev (20.660792ms)
  Error: enceError [Error]: after is not defined

@at-the-vr
Copy link
Member Author

Thanks for the pinpointing the error, it completely went undetected when I was locally testing

@ematipico ematipico merged commit 116cfb6 into withastro:main Feb 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants