CLI paths take the PC Root, not the project's path root.

[muchisx]

Astro Info

"Astro                    v3.2.2\nNode                     v18.16.0\nSystem                   Windows (x64)\nPackage Manager          npm\nOutput                   server\nAdapter                  @astrojs/vercel/serverless\nIntegrations             @custom/update-webflow-js\n                         @astrojs/tailwind\n                         @astrojs/preact\n                         @astrojs/prefetch\n                         astro-robots-txt"

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

The Astro CLI during npm run dev is using my entire pc path for outputs, can this be modified to instead use the project's root path?

What's the expected result?

I would think the project's root path is better! instead of the entire PC path !

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-n2mknz?file=README.md

Participation

• I am willing to submit a pull request for this issue.

[lilnasy]

Seems to be the full path only on windows.

[florian-lefebvre]

@lilnasy is this logic happening here

astro/packages/astro/src/vite-plugin-astro/hmr.ts

Line 94 in b405b03

const file = ctx.file.replace(config.root.pathname, '/');

? Looks like it's replaced already so not sure what's going on

[lilnasy]

Thanks for looking into it!

I think either ctx.file or config.root.pathname needs URI decoding ("%20" into the space character.)

If that is the case, I would expect the full path to appear when there are special characters in the path on any OS.

[florian-lefebvre]

I have also the same thing right now with no space nor special character in the path, not sure to understand what you mean 🤔

[lilnasy]

Nevermind, it's not that. When pathname is read from a URL object (config.root in this case), it starts with a forwards slash, which prevents replace's pattern from matching.

[lilnasy]

...in addition to the undecoded URI, which affects non-Windows platforms as well.

[florian-lefebvre]

Not sure where to look then 🤔, I'm not familiar enough with the codebase

[lilnasy]

@florian-lefebvre You already got it actually. The hmr.ts line you linked is the appropriate place. You might find fileUrlToPath function from "node:url" helpful.