Skip to content

Commit

Permalink
Add autocomplete to button JSX type (#9522)
Browse files Browse the repository at this point in the history
* Add autocomplete to button JSX type

This is “nonstandard and Firefox-specific” but often required when working with dynamic disabled state.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#autocomplete

* Run `pnpm exec changeset`
  • Loading branch information
Zegnat authored Dec 25, 2023
1 parent eb36e95 commit bb1438d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/beige-zebras-ring.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Add support for autocomplete attribute to the HTML button type.
1 change: 1 addition & 0 deletions packages/astro/astro-jsx.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -627,6 +627,7 @@ declare namespace astroHTML.JSX {
}

interface ButtonHTMLAttributes extends HTMLAttributes {
autocomplete?: string | undefined | null;
disabled?: boolean | string | undefined | null;
form?: string | undefined | null;
formaction?: string | undefined | null;
Expand Down

0 comments on commit bb1438d

Please sign in to comment.