fix: change strategy for route caching

withastro · Feb 27, 2024 · 83a4a0f · 83a4a0f
1 parent bc2bf46
commit 83a4a0f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/great-flowers-own.md b/.changeset/great-flowers-own.md
@@ -0,0 +1,5 @@
+---
+"astro": patch
+---
+
+Fixes an issue where multiple injected routes with the same `entrypoint` but different `pattern` were incorrectly cached, causing some of them not being rendered in the dev server.
diff --git a/packages/astro/src/core/render/route-cache.ts b/packages/astro/src/core/render/route-cache.ts
@@ -102,14 +102,14 @@ export class RouteCache {
 		// NOTE: This shouldn't be called on an already-cached component.
 		// Warn here so that an unexpected double-call of getStaticPaths()
 		// isn't invisible and developer can track down the issue.
-		if (this.mode === 'production' && this.cache[route.component]?.staticPaths) {
-			this.logger.warn(null, `Internal Warning: route cache overwritten. (${route.component})`);
+		if (this.mode === 'production' && this.cache[route.route]?.staticPaths) {
+			this.logger.warn(null, `Internal Warning: route cache overwritten. (${route.route})`);
 		}
-		this.cache[route.component] = entry;
+		this.cache[route.route] = entry;
 	}
 
 	get(route: RouteData): RouteCacheEntry | undefined {
-		return this.cache[route.component];
+		return this.cache[route.route];
 	}
 }