-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use absolute path for included files #313
Conversation
🦋 Changeset detectedLatest commit: b410221 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe we can release a preview for the affected user to confirm?
Snapshots have been released for the following packages:
Publish Log
Build Log
|
Can confirm that it works now in my monorepo setup! Thanks for the quick fix. |
Changes
The adapter adds an
included_files
option to the SSR function manifest to ensure that all traced files are included in the bundle. The path is currently relative to the root of the site, which breaks when in a monorepo. This PR changes the path to be absolute, which works everywhere. Using an absolute path is fine because bundling always happens on the same machine as the build.Fixes #309
Testing
Test deploy: https://66826aaccd6edbca0c286764--fascinating-belekoy-dfd085.netlify.app/
Docs