Bump to 1.0.4 + miscellaneous maintenance #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a deprecation warning to do with calling `use Mix.Config` Since libraries aren't intended to set application config anyway, we should just delete the directory.
By default, if MIX_ENV is unset, mix tasks run using the :dev environment. This is required to ensure that tests are run when calling `mix quality` with no explicit environment.
The `...>` notation is reserved for multiline expressions. If the previous expression is intended to be ignored, then no changes in the syntax are required. This resolves a number of warnings about unused literals and causes some missed tests to be run correctly.
This resolves a compile warning.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The first is a pattern that's very common within the codebase, and the second is incompatible with Semigroupoid.apply/2
QuinnWilton
force-pushed
the
quinn/1.0.4
branch
from
15d389e to
bc78824
Compare
expede
reviewed
Jan 24, 2022
Comment on lines
+12
to
+15
| {Credo.Check.Readability.MaxLineLength, priority: :low, max_length: 100}, | ||
| {Credo.Check.Readability.PipeIntoAnonymousFunctions, false}, | ||
| # This rule incorrectly flags uses of Witchcraft.Semigroupoid.apply/2 | ||
| {Credo.Check.Refactor.Apply, false} |
There was a problem hiding this comment.
Hmm I wonder if we should rework the relevant parts of the library to make them compatible with the updated community naming conventions 🤔 I'll open an Issue at minimum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another small release that mostly updates dependencies and performs some miscellaneous maintenance. Importantly though, it updates to the new versions of
quarkandtype_class, which add compatibility for running under Elixir 1.13.Making these changes did reveal a risk that we may need to be aware of though: it looks like
^^^may be deprecated and planned for removal in Elixir 2.0.0. I'm waiting on clarification from the core team as to whether the operator is being removed entirely, or whether it's just its use inBitwise.bxor/2that's being removed, but that can be tracked here: elixir-lang/elixir#11590Depending on their response, I'll make an issue to track finding a solution in
witchcraftfor the operator's use with Arrows.