Skip to content

test: modified I press function to add MTMOODLE-109 compatibility #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+8 −5
Open

test: modified I press function to add MTMOODLE-109 compatibility #189

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fc8901
test: modified I press function to add MTMOODLE-109 compatibility
dadalid-at-wiris Aug 13, 2025
ad99479
test:fix lint errors
dadalid-at-wiris Aug 13, 2025
41eb6d2
test: fix MTMOODLE-109, adding an extra click to avoid interception w…
dadalid-at-wiris Aug 14, 2025
d18c8d0
test: fix collateral damage when fixing MTMOODLE-109
dadalid-at-wiris Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions tests/behat/behat_wiris_page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,7 @@ public function i_press_in_field_in_tiny_editor($button, $field) {
"General feedback" => "fitem_id_generalfeedback",
"Feedback" => "fitem_id_feedback_0",
"Message" => "fitem_id_message",
"Text Block" => "fitem_id_config_text",
];
if (empty($sectionarray[$field])) {
throw new ExpectationException($field . " field not registered.", $this->getSession());
Expand All @@ -335,18 +336,18 @@ public function i_press_in_field_in_tiny_editor($button, $field) {
throw new ExpectationException($button . " button not registered.", $this->getSession());
}
$session = $this->getSession();
$component = $session->getPage()->find('xpath', '//div[@id="' . $sectionarray[$field] . '"]
$component = $session->getPage()->find('xpath', '//div[contains(@id,"' . $sectionarray[$field] . '")]
//*[contains(@title,\'' . $buttonarray[$button] . '\')]');

// In Moodle 4.4 the button has change from "More.." to "Reveal or hide..."
if ($button == 'Toggle' && $CFG->version >= 2024042202.02) {
$component = $session->getPage()->find('xpath', '//div[@id="' . $sectionarray[$field] . '"]
$component = $session->getPage()->find('xpath', '//div[contains(@id,"' . $sectionarray[$field] . '")]
//*[contains(@aria-label,"Reveal or hide")]');
}

// From 4.5, the button is not found via id but via data-mce-name //TODO verify if 4.x may always work like this
if ($button != 'Toggle' && $CFG->version >= 2024092400) {
$component = $session->getPage()->find('xpath', '//div[@id="' . $sectionarray[$field] . '"]
$component = $session->getPage()->find('xpath', '//div[contains(@id,"' . $sectionarray[$field] . '")]
//*[contains(@aria-label,"' . $buttonarray[$button] . '")]');
}

Expand Down Expand Up @@ -613,16 +614,18 @@ public function i_click_on_in_tinymce_6_editor_toolbar($button) {
global $CFG;
$buttonarray = [
"More options" => "More...",
"Align left" => "Align left"
];
if (empty($buttonarray[$button])) {
throw new ExpectationException($button . " button not registered.");
}
$session = $this->getSession();
$component = $session->getPage()->find('xpath', '//button[@title="' . $buttonarray[$button] . '"]');
if ($CFG->version >= 2024042202.02) {
$component = $session->getPage()->find('xpath', '//*[contains(@aria-label,"Reveal or hide")]');
$buttonarray["More options"] = "Reveal or hide"; // In Moodle 4.4 the button has change from "More.." to "Reveal or hide"
echo '//*[contains(@aria-label,"' . $buttonarray[$button] . '")]';
$component = $session->getPage()->find('xpath', '//*[contains(@aria-label,"' . $buttonarray[$button] . '")]');
}

if (empty($component)) {
throw new ExpectationException($button . " button not correctly recognized.", $this->getSession());
}
Expand Down
Loading