Entity Markers refactor #3459
Merged
Entity Markers refactor #3459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegrb93
reviewed
Nov 4, 2025
Contributor
|
You should split refactors up into seperate PRs by entity. The freezer changes shouldn't be in this one. |
Contributor
|
Because the bigger the PR, the longer it will sit with no one wanting to review it. |
Contributor
Author
For the most part, these codes are just copy-paste |
Contributor
Author
|
Anyway, i tested this PR a lot, so i'm sure nothing will break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code cleanups
More useful overlaytext
Fixed a bug where, when connecting one entity to several markers, they would not be unlinked when it was removed + remove callonremove callback after unlink