Skip to content

Conversation

@Fasteroid
Copy link
Contributor

More Models + Modelplug Cleanup

This PR gives a much-needed refactoring to cl_modelplug.lua and removes some redundant legacy sanity tests.
It also adds some new models I made, because hell, when have we last gotten new models?

New Models

image
LEDs (in normal, mini, and nano, for wire lights)
Computer Fan (has skins, is animated, thruster and forcer)
Pointer Hand (has skins, a funny model for gimbals)

Publishing this as a draft for now—more good ideas are still to be had.
Looking forward to hearing feedback from the community.

@Fasteroid Fasteroid marked this pull request as draft May 3, 2023 21:29
@shadowscion
Copy link
Contributor

shadowscion commented May 5, 2023

when have we last gotten new models?

I checked... ten years ago! Surprising.

Fasteroid added 2 commits May 5, 2023 13:16
(this was way too large)
@Fasteroid
Copy link
Contributor Author

image
new inductor model

@Fasteroid Fasteroid marked this pull request as ready for review May 19, 2023 15:01
@Fasteroid
Copy link
Contributor Author

Setting this back to draft so I can add some new cable types to wire plug (Like USB-C)

@Fasteroid Fasteroid marked this pull request as draft May 28, 2023 15:05
tabs OR spaces, NOT BOTH!
data plug has been missing models for years!
Fasteroid added 2 commits May 28, 2023 14:13
add usb-c plug and socket
fix bugs from unspaghetti commit
plugs play confirmation sound when linked
@Fasteroid
Copy link
Contributor Author

Fasteroid commented May 31, 2023

image

@thegrb93
Copy link
Contributor

thegrb93 commented Jun 1, 2023

Setting this back to draft so I can add some new cable types to wire plug (Like USB-C)

Can't you do a new PR?

@Fasteroid
Copy link
Contributor Author

Can't you do a new PR?

would prefer this to be a one-and-done thing since new models will require a workshop update

@thegrb93
Copy link
Contributor

thegrb93 commented Jun 4, 2023

K

@Fasteroid
Copy link
Contributor Author

image

@Fasteroid Fasteroid marked this pull request as ready for review July 6, 2023 00:27
@Fasteroid
Copy link
Contributor Author

Marking this as ready since I'm done making new models for now. If anyone has special requests please ask and I'll make them.

@Fasteroid
Copy link
Contributor Author

Not lint fixing motor since I didn't touch it in this commit.

@thegrb93
Copy link
Contributor

thegrb93 commented Jul 6, 2023

@Vurv78 Will need a workshop update after this one gets merged

@Fasteroid
Copy link
Contributor Author

@Vurv78 Will need a workshop update after this one gets merged

Perfect time to test the workshop auto-update actions

@thegrb93 thegrb93 merged commit 6893cb4 into wiremod:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants