Fix test runs in Maven #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
approved these changes
Apr 19, 2023
Member
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
It is a bit weird for JUnit 5 dependencies, but I rarely do projects without a parent POM where all JUnit 4/5 alignment is already sorted. Definitely fine to remove JUnit 5 for now, formal support is on my TODO list
| .withMapping("json-body-transformer", WireMockContainerExtensionTest.class, "json-body-transformer.json") | ||
| .withExtension("JSON Body Transformer", Collections.singleton("com.ninecookies.wiremock.extensions.JsonBodyTransformer"), | ||
| Collections.singleton(Paths.get("target", "test-wiremock-extension", "9cookies-wiremock-extensions.jar").toFile())); | ||
| Collections.singleton(Paths.get("target", "test-wiremock-extension", "wiremock-extensions-0.4.1-jar-with-dependencies.jar").toFile())); |
Member
There was a problem hiding this comment.
Ugh, renamed it and missed in the release. Thanks!
| </dependency> | ||
| <dependency> | ||
| <groupId>ch.qos.logback</groupId> | ||
| <artifactId>logback-classic</artifactId> |
Member
There was a problem hiding this comment.
Yeah, this is definitely better than my attempts to just capture streams through Testcontainers APIs, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, test doesn't run when performing
mvn verify. By removingjunit jupiter dependencies tests started running. Also, in order to
run all tests successfully wiremock extension should resolve in compile
phase. Finally, enable container logs.