Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor linting tweaks #5

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Conversation

jamietanna
Copy link
Contributor

As per discussion on Slack, a few minor tweaks that would be picked up by common linting rules in Go projects.

References

  • N/A

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide) Note there doesn't seem to be one?
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@oleg-nenashev oleg-nenashev added the chore Maintenance label Jul 11, 2023
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jamietanna!

@jamietanna
Copy link
Contributor Author

You're welcome - is there anything else we need to do for reviews or to get it merged? I don't have commit access

@oleg-nenashev oleg-nenashev merged commit b9b8f0d into wiremock:main Jul 12, 2023
1 check passed
@oleg-nenashev
Copy link
Member

Nope, merged it! If you are interested in becoming a co-maintainer for this component, no objections as well 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants