Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content gone in 1.9.2 but works in 1.9.1 #19

Closed
StephanSchuster opened this issue Nov 23, 2021 · 2 comments · Fixed by #20
Closed

Content gone in 1.9.2 but works in 1.9.1 #19

StephanSchuster opened this issue Nov 23, 2021 · 2 comments · Fixed by #20
Assignees
Labels

Comments

@StephanSchuster
Copy link

I just upgraded from 1.7.5 to 1.9.2 and most of my app's content was not shown anymore. In lots of places I fade in/out content with AdditiveAnimator. After two hours of searching for the root cause I switched from 1.9.2 back to 1.9.1 and suddenly everything is working again.

Might there be a bug in 1.9.2? I saw that lots of visibility/fade related framework code has been changed in 1.9.2.

This is a typical pattern which works in 1.9.1 but does NOT work in 1.9.2:

AdditiveAnimator.animate(contentViews)
    .setDuration(UI.CARDS_INTRO_DURATION)
    .setInterpolator(new DecelerateInterpolator())
    .fadeVisibility(show ? View.VISIBLE : View.GONE)
    .start();

Am I missing something?

@davidganster
Copy link
Member

Hi Stephan,

sorry to hear about your problems with 1.9.2!

I investigated your report and there's definitely a problem with how the ViewVisibilityBuilder constructs its animation start- and end-actions.
We didn't catch this in our own applications since we have used custom visibility animations for a long time, and the issue only manifests if you never specify your own animation start/end actions.

I've identified and fixed the issue, and will release 1.9.3 asap.

Thanks for the report!

Cheers
David

@davidganster davidganster self-assigned this Nov 23, 2021
davidganster pushed a commit that referenced this issue Nov 23, 2021
@davidganster davidganster linked a pull request Nov 23, 2021 that will close this issue
davidganster added a commit that referenced this issue Nov 23, 2021
…d_actions

#19 fix animation start/end actions not being called
@StephanSchuster
Copy link
Author

Wow, that was fast. Thank you @davidganster. I upgraded to 1.9.3 meanwhile. No issues. Perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants