-
Notifications
You must be signed in to change notification settings - Fork 333
WPB-20053: fix Brig's emails templates fetch script #4878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
supersven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you've tried it (i.e. it works, which I haven't tested), fine by me 👍
|
@blackheaven Please take care of the checklist in this PR. Adding a changelog entry would be good. |
|
added, thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to fix Brig's email templates fetch script by updating the path to the templates directory. The script previously looked for templates in a local subdirectory, but the change redirects it to libs/wire-subsystems/templates to reflect the actual location of email templates in the repository.
Key changes:
- Updates the
templatespath variable in the fetch script to point to the shared templates location - Adds a changelog entry documenting the bug fix
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| services/brig/deb/opt/brig/bin/fetch.py | Updates the templates directory path to point to libs/wire-subsystems/templates |
| changelog.d/3-bug-fixes/WPB-20053 | Adds changelog entry for the bug fix |
Critical Issue Identified: The path construction in fetch.py is incorrect - it only goes up 2 directory levels when it needs to go up 5 levels to reach the repository root where the libs/ directory is located.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Checklist
changelog.d