Skip to content

Conversation

@blackheaven
Copy link
Contributor

@blackheaven blackheaven commented Nov 27, 2025

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@blackheaven blackheaven requested a review from a team as a code owner November 27, 2025 16:49
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Nov 27, 2025
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you've tried it (i.e. it works, which I haven't tested), fine by me 👍

@supersven
Copy link
Contributor

@blackheaven Please take care of the checklist in this PR. Adding a changelog entry would be good.

@blackheaven blackheaven requested review from a team as code owners November 28, 2025 07:58
@blackheaven
Copy link
Contributor Author

added, thanks :)

@battermann battermann requested a review from Copilot November 28, 2025 09:31
Copilot finished reviewing on behalf of battermann November 28, 2025 09:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to fix Brig's email templates fetch script by updating the path to the templates directory. The script previously looked for templates in a local subdirectory, but the change redirects it to libs/wire-subsystems/templates to reflect the actual location of email templates in the repository.

Key changes:

  • Updates the templates path variable in the fetch script to point to the shared templates location
  • Adds a changelog entry documenting the bug fix

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
services/brig/deb/opt/brig/bin/fetch.py Updates the templates directory path to point to libs/wire-subsystems/templates
changelog.d/3-bug-fixes/WPB-20053 Adds changelog entry for the bug fix

Critical Issue Identified: The path construction in fetch.py is incorrect - it only goes up 2 directory levels when it needs to go up 5 levels to reach the repository root where the libs/ directory is located.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants