WPB-21964: Add Wire Meetings endpoints #4872
Conversation
zebot
added
the
ok-to-test
blackheaven
force-pushed
the
gdifolco/WPB-21964-wire-meetings-skeleton
branch
from
ba6264c to
425ab2d
Compare
| conversation_id UUID NOT NULL, | ||
| conversation_domain TEXT NOT NULL, | ||
| invited_emails TEXT[] DEFAULT '{}', | ||
| trial BOOLEAN DEFAULT FALSE, |
|
|
||
| -- Determine trial status | ||
| -- TODO: Check if user is a paying customer via Feature | ||
| let trial = False |
There was a problem hiding this comment.
Do you know which feature flag should be checked?
| then pure False | ||
| else do | ||
| -- Add invited email | ||
| Store.addInvitedEmail meetingId email |
There was a problem hiding this comment.
@akshaymankar Can I send e-mails in an upcoming PR?
| -- Validate that endDate > startDate | ||
| when (newMeeting.endDate <= newMeeting.startDate) $ | ||
| throwS @'InvalidOperation | ||
| Meetings.createMeeting lUser newMeeting |
There was a problem hiding this comment.
@akshaymankar Should we send new conversations notifications?
akshaymankar
left a comment
akshaymankar
left a comment
There was a problem hiding this comment.
There are more questions about this in the RFC. Let's wait before implementation.
| startDate :: UTCTime, | ||
| endDate :: UTCTime, | ||
| schedule :: Maybe Text, | ||
| conversationId :: Qualified ConvId, |
There was a problem hiding this comment.
It might be best to keep this not qualified as the meeting id is qualified and we probably don't want to deal with meetings whose convs are remote.
There was a problem hiding this comment.
should change the RFC?
| creator :: UserId, | ||
| startDate :: UTCTime, | ||
| endDate :: UTCTime, | ||
| schedule :: Maybe Text, |
There was a problem hiding this comment.
IMO the cron format is a mistake here, there is some discussion about it in the RFC. We should wait for that to resolve.
blackheaven
force-pushed
the
gdifolco/WPB-21964-wire-meetings-skeleton
branch
from
63d6831 to
0c273b7
Compare
https://wearezeta.atlassian.net/browse/WPB-21964
Checklist
changelog.d