brig-index: Don't fail when a user doc fails to build #4839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o build Instead just log and move on. This removes the effect and implement all actions as IO by passing the interpreter and calling it everywhere. This is not the prettiest way to do this, perhaps we figure out a way later.
zebot
added
the
ok-to-test
fisx
reviewed
Nov 6, 2025
| syncAllUsersWithVersion interpreter mkVersion = | ||
| runConduit $ | ||
| zipSources (CL.sourceList [1 ..]) (paginateWithStateC (getIndexUsersPaginated pageSize)) | ||
| zipSources (CL.sourceList [1 ..]) (paginateWithStateC (interpreter . getIndexUsersPaginated pageSize)) |
Contributor
There was a problem hiding this comment.
hehe, nice hack. makes sense to me!
(why is this not how we want to do things? :-))
Member
Author
There was a problem hiding this comment.
The function is aware of all the transitive dependencies of the interpreters of the effects it depends on. This makes substituting them basically impossible. So all the polysemy things we do here are pointless.
akshaymankar
force-pushed
the
better-brig-index
branch
from
15c5af9 to
85f5694
Compare
jschaul
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-21555
Checklist
changelog.d