coturn: Allow setting of K8s annotations at the Service #4189
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can e.g. be used to set external-dns annotations. Or, any other annotations (depending on the setup of the K8s cluster.)
zebot
added
the
ok-to-test
MangoIV
pushed a commit
that referenced
this pull request
Aug 7, 2024
This can e.g. be used to set external-dns annotations. Or, any other annotations (depending on the setup of the K8s cluster.)
echoes-hq
bot
added
the
echoes: product-roadmap
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can e.g. be used to set external-dns annotations. Or, any other annotations (depending on the setup of the K8s cluster.) We'll be using it in our internal deployments to configure
external-dns.I've tested this manually on
sven-testby pointing thechartof the Helm release to my local checkout.Checklist
changelog.d