Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx-zauth-module: Do not try to read the access token from query params #4175

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

nginx-zauth-module: Do not try to read the access token from query params #4175

wants to merge 2 commits into from

Conversation

akshaymankar
Copy link
Member

https://wearezeta.atlassian.net/browse/WPB-5260

Depends on wireapp/wire-webapp#17842. There needs to be another PR made to wire-web-packages to further stop using the tokens.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes: technical-roadmap/security Security related changes or defects label Jul 30, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 30, 2024
@akshaymankar
Copy link
Member Author

⚠️ This breaks websockets because browsers don't allow adding HTTP headers to requests. See https://stackoverflow.com/a/77060459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
echoes: technical-roadmap/security Security related changes or defects ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaymankar @zebot