Introduce EmailSmsSubsystem, use it for a few emails and password reset SMS #4111
+1,375
−1,194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
battermann
changed the base branch from
develop
to
WPB-8890-polysemy-user-subsystem-add-password-reset-operation-s
echoes-hq
bot
added
echoes: technical-roadmap/throughput
akshaymankar
force-pushed
the
WPB-8890-polysemy-user-subsystem-add-password-reset-operation-s
branch
from
baf9c13
to
9eff1d1
Compare
battermann
changed the title
battermann
force-pushed
the
WPB-9831-send-password-reset-emails-texts-using-subsystems
branch
from
0c66016
to
41d7d11
Compare
akshaymankar
reviewed
Jul 1, 2024
fisx
reviewed
Jul 1, 2024
Comment on lines
+23
to
+26
| ------------------------------------------------------------------------------- | ||
| -- Verification Email for | ||
| -- - Login | ||
| -- - Creation of ScimToken | ||
| -- - Team Deletion |
There was a problem hiding this comment.
this grouping seems random. split up into 3 comments?
There was a problem hiding this comment.
They're all verification emails, I don't see any harm in this.
libs/wire-subsystems/test/unit/Wire/MockInterpreters/EmailSmsSubsystem.hs
Outdated
Show resolved
Hide resolved
libs/wire-subsystems/test/unit/Wire/MockInterpreters/UserStore.hs
Outdated
Show resolved
Hide resolved
Base automatically changed from
WPB-8890-polysemy-user-subsystem-add-password-reset-operation-s
to
develop
July 1, 2024 08:59
Co-authored-by: Akshay Mankar <akshay@wire.com>
Co-authored-by: Akshay Mankar <akshay@wire.com>
fisx
force-pushed
the
WPB-9831-send-password-reset-emails-texts-using-subsystems
branch
from
d42e28b
to
5e3a8e6
Compare
2 tasks
…ord-reset-emails-texts-using-subsystems' into WPB-9831-send-password-reset-emails-texts-using-subsystems
akshaymankar
approved these changes
Jul 2, 2024
akshaymankar
changed the title
akshaymankar
deleted the
WPB-9831-send-password-reset-emails-texts-using-subsystems
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-9831
This PR is based on #4086. So when #4086 is merged, we need to rebase this on develop.
Checklist
changelog.d