Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPB-8764] Backport changes from q1-2024 to develop (Apr 23, 2024) #4014

Merged
merged 8 commits into from
Apr 24, 2024

Conversation

smatting and others added 7 commits April 23, 2024 16:42
…sting and target user (#3923)

Previous logic limited how many keys could be claimed for one user, but
continued limiting claims on multiple users. This causes problems while creating
conversations when a lot of key package claims are needed.

This commit introduces a concept of specific_rate_limits which allow setting
multiple rate limit zones in nginz. Here we use one for limiting how many key
packages can be claimed by a user per target and another for limiting how many
key packages claimed by a user for any target.
To ensure certificate revocations get active in a short time frame, disable
caching of proxy results on client side by setting respective HTTP headers.
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 24, 2024
@mdimjasevic mdimjasevic marked this pull request as ready for review April 24, 2024 08:40
Copy link
Contributor

@smatting smatting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The state of charts/smallstep-accomp should match the one from the q1-2024 branch. But it doesn't. See

git diff origin/wpb-8764/port-missing-commits-from-q1-2024..origin/q1-2024 -- charts/smallstep-accomp

@mdimjasevic
Copy link
Contributor Author

The state of charts/smallstep-accomp should match the one from the q1-2024 branch. But it doesn't. See

git diff origin/wpb-8764/port-missing-commits-from-q1-2024..origin/q1-2024 -- charts/smallstep-accomp

Thanks! I'll apply your observation.

@mdimjasevic
Copy link
Contributor Author

The state of charts/smallstep-accomp should match the one from the q1-2024 branch. But it doesn't. See

git diff origin/wpb-8764/port-missing-commits-from-q1-2024..origin/q1-2024 -- charts/smallstep-accomp

@smatting , now no more diff according to the command. Can you take another look?

@mdimjasevic mdimjasevic changed the title [WPB-8764] Backport changes from q1-2024 to develop (Apr 23, 2024) [WPB-8764] Backport changes from q1-2024 to develop (Apr 23, 2024) Apr 24, 2024
@mdimjasevic mdimjasevic merged commit cf1e857 into develop Apr 24, 2024
8 checks passed
@mdimjasevic mdimjasevic deleted the wpb-8764/port-missing-commits-from-q1-2024 branch April 24, 2024 11:16
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt Changes intended at mitigating risks label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/technical-debt Changes intended at mitigating risks ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants