Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Port 2FA tests #3986

Merged
merged 8 commits into from
Apr 9, 2024
Merged

[chore] Port 2FA tests #3986

merged 8 commits into from
Apr 9, 2024

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Apr 9, 2024 •
edited
Loading

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 9, 2024
fisx
fisx approved these changes Apr 9, 2024
View reviewed changes
integration/test/Test/Login.hs
generateVerificationCode owner email
code <- getVerificationCode owner "login" >>= getJSON 200 >>= asString
bindResponse (loginWith2ndFactor owner email defPassword code) $ \resp -> do
resp.status `shouldMatchInt` 200
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the old test, we were checking the json content as well, i think that was useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find it, can you point me to it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/wireapp/wire-server/pull/3986/files#diff-5d67659df46f564af0bf4bf2cfa2977d5be77b859c66c70cb18fe7c6571b9393L449-L455

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, i was reading it wrong. all good!

integration/test/Test/Login.hs Outdated Show resolved Hide resolved
integration/test/Test/Login.hs Outdated Show resolved Hide resolved
@battermann battermann merged commit e4020b8 into develop Apr 9, 2024
8 checks passed
@battermann battermann deleted the battermann/port-2fa-tests branch April 9, 2024 15:09
@battermann battermann mentioned this pull request Apr 9, 2024
Closed
2 tasks
fisx pushed a commit that referenced this pull request Apr 15, 2024
@battermann @fisx
[chore] Port 2FA tests (#3986)
90117b5
@zebot zebot mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisx fisx fisx approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@battermann @fisx @zebot