Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gundeck: Make notificationTTL configurable #3960

Merged
merged 2 commits into from
Mar 20, 2024
Merged

gundeck: Make notificationTTL configurable #3960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daa4036
gundeck: Make notificationTTL configurable
supersven Mar 18, 2024
c188051
Refine comment
supersven Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog.d/2-features/gundeck-configure-notificationTTL
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Make gundeck's notificationTTL configurable. The value defines how long
notifications are (at most) stored in the database. Decreasing this value e.g.
helps to safe database space on test environments.
supersven marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion charts/gundeck/templates/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ data:

settings:
httpPoolSize: 1024
notificationTTL: 2419200
notificationTTL: {{ required "config.notificationTTL" .notificationTTL }}
bulkPush: {{ .bulkPush }}
{{- if hasKey . "perNativePushConcurrency" }}
perNativePushConcurrency: {{ .perNativePushConcurrency }}
Expand Down
5 changes: 5 additions & 0 deletions charts/gundeck/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ config:
# the database if notifications have inlined payloads.
internalPageSize: 100

# TTL of stored notifications in Seconds. After this period, notifications
# will be deleted and thus not delivered.
# The default is 28 days.
supersven marked this conversation as resolved.
Show resolved Hide resolved
notificationTTL: 2419200

serviceAccount:
# When setting this to 'false', either make sure that a service account named
# 'gundeck' exists or change the 'name' field to 'default'
Expand Down
Loading