Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gundeck: Fix SNS endpoint parser (backport q1-2024) #3928

Merged
merged 1 commit into from
Mar 11, 2024
Merged

gundeck: Fix SNS endpoint parser (backport q1-2024) #3928

merged 1 commit into from
Mar 11, 2024
+97 −10

Conversation

akshaymankar
Copy link
Member

This commit contains two things:

  1. Add fields to the log message such that mismatches between stored and app-provided data become more obvious.
  2. Fix an AWS SNS Endpoint parsing bug: We parsed the environment up to the first dash. But, environment names may contain dashes themselves, thus we must accumulate them up to the last dash.

Tickets:

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@supersven @akshaymankar
gundeck: Fix SNS endpoint parser (#3894)
4940547 
This commit contains two things:

1. Add fields to the log message such that mismatches between stored and app-provided data become more obvious.
2. Fix an AWS SNS Endpoint parsing bug: We parsed the environment up to the first dash. But, environment names may contain dashes themselves, thus we must accumulate them up to the last dash.
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 6, 2024
@akshaymankar akshaymankar merged commit 4991a55 into q1-2024 Mar 11, 2024
8 checks passed
@akshaymankar akshaymankar deleted the backport-3894 branch March 11, 2024 11:40
@smatting smatting mentioned this pull request May 28, 2024
Closed
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanwire stefanwire stefanwire approved these changes

Assignees
No one assigned
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akshaymankar @stefanwire @zebot @supersven