Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federation-v0 setup in integration tests #3849

Merged
merged 12 commits into from
Feb 15, 2024
Merged

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Jan 31, 2024

This PR finishes the setup of the federation-v0 backend in integration tests and makes it possible to write tests that use it.

It also makes federator ingresses use cert-manager in CI, so they can share an issuer with the federation-v0 instance and get certificates that are suitable for talking to each other.

https://wearezeta.atlassian.net/browse/WPB-183

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@pcapriotti pcapriotti marked this pull request as draft January 31, 2024 09:17
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 31, 2024
@stefanwire stefanwire force-pushed the v0-integration-setup branch 2 times, most recently from 0778464 to 6521cec Compare February 9, 2024 15:00
@pcapriotti pcapriotti marked this pull request as ready for review February 9, 2024 15:17
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (Only a couple of small remarks.)

hack/bin/integration-setup-federation.sh Outdated Show resolved Hide resolved
charts/integration/templates/ingress.yaml Show resolved Hide resolved
hack/helmfile.yaml Show resolved Hide resolved
@stefanwire stefanwire merged commit 41183b7 into develop Feb 15, 2024
8 checks passed
@stefanwire stefanwire deleted the v0-integration-setup branch February 15, 2024 11:15
stefanwire added a commit that referenced this pull request Feb 15, 2024
Co-authored-by: Stefan Berthold <stefan.berthold@wire.com>
Co-authored-by: Sven Tennie <sven.tennie@wire.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants