-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Federation-v0 setup in integration tests #3849
Merged
Merged
+152
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
Approved for running tests in CI, overrides not-ok-to-test if both labels exist
label
Jan 31, 2024
pcapriotti
force-pushed
the
v0-integration-setup
branch
from
February 1, 2024 14:41
27c7c4d
to
e5f7911
Compare
stefanwire
force-pushed
the
v0-integration-setup
branch
2 times, most recently
from
February 9, 2024 15:00
0778464
to
6521cec
Compare
pcapriotti
force-pushed
the
v0-integration-setup
branch
from
February 13, 2024 13:20
bcdac29
to
5fed86a
Compare
supersven
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 (Only a couple of small remarks.)
Co-authored-by: Sven Tennie <sven.tennie@wire.com>
stefanwire
added a commit
that referenced
this pull request
Feb 15, 2024
Co-authored-by: Stefan Berthold <stefan.berthold@wire.com> Co-authored-by: Sven Tennie <sven.tennie@wire.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes the setup of the federation-v0 backend in integration tests and makes it possible to write tests that use it.
It also makes federator ingresses use cert-manager in CI, so they can share an issuer with the federation-v0 instance and get certificates that are suitable for talking to each other.
https://wearezeta.atlassian.net/browse/WPB-183
Checklist
changelog.d