Create subconversations on first commit #3355
Merged
+200
−158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcapriotti
force-pushed
the
pcapriotti/mls-subconv-creation
branch
from
d9523b6
to
4a842c3
Compare
pcapriotti
force-pushed
the
pcapriotti/mls-subconv-creation
branch
from
8999b8b
to
98e8559
Compare
zebot
added
the
ok-to-test
smatting
approved these changes
Jun 16, 2023
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way subconversations are created to be consistent with the approach used for MLS 1-1 conversations. Namely, instead of the GET endpoint creating the conversation when it doesn't exist, creation happens within the commit lock of the first commit.
This also fixes a latent race condition where one thread could "create" an existing conversation which had already progressed to epoch 1, thereby resetting its epoch to 0 and breaking it.
https://wearezeta.atlassian.net/browse/WPB-1927
Checklist
changelog.d