Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul the auth cookie documentation #2941

Merged
merged 4 commits into from
Dec 21, 2022
Merged

Overhaul the auth cookie documentation #2941

merged 4 commits into from
Dec 21, 2022

Conversation

supersven
Copy link
Contributor

  • Fix wrong statements
  • Add configuration example

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@supersven
Overhaul the auth cookie documentation
4669a90 
- Fix wrong statements
- Add configuration example
@supersven supersven temporarily deployed to cachix December 20, 2022 07:29 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix December 20, 2022 07:29 — with GitHub Actions Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Dec 20, 2022
@supersven supersven temporarily deployed to cachix December 20, 2022 07:58 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix December 20, 2022 07:58 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix December 20, 2022 08:54 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix December 20, 2022 08:54 — with GitHub Actions Inactive
pcapriotti
pcapriotti approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor comments below.

changelog.d/4-docs/auth-cookie Outdated Show resolved Hide resolved
docs/src/how-to/install/configuration-options.rst Outdated Show resolved Hide resolved
docs/src/understand/api-client-perspective/authentication.rst Outdated Show resolved Hide resolved
docs/src/understand/api-client-perspective/authentication.rst Outdated Show resolved Hide resolved
@supersven supersven marked this pull request as ready for review December 20, 2022 17:20
@supersven supersven temporarily deployed to cachix December 20, 2022 17:27 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix December 20, 2022 17:27 — with GitHub Actions Inactive
@supersven
Copy link
Contributor Author

Looks good. Minor comments below.

@pcapriotti , Thanks a lot for grammar and spell checking!

@supersven supersven merged commit 9211b1b into develop Dec 21, 2022
@supersven supersven deleted the sventennie/add_auth_cookie_docs branch December 21, 2022 05:57
@zebot zebot mentioned this pull request Jan 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcapriotti pcapriotti pcapriotti approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@supersven @pcapriotti @zebot