Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the subconversation types and change federation message sending request types #2925

Merged
merged 5 commits into from
Dec 13, 2022

Conversation

mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented Dec 13, 2022

This PR is in preparation for https://wearezeta.atlassian.net/browse/FS-901, i.e., for introducing endpoints for MLS subconversations.

The PR introduces subconversation types, which affect the federation API for MLS message sending requests as eventually we want to be able to use subconversations on remote backends. Note that the PR does not introduce any subconversation functionality; it just introduces needed types.

This is a federation API breaking change.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@mdimjasevic mdimjasevic temporarily deployed to cachix December 13, 2022 14:34 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix December 13, 2022 14:34 — with GitHub Actions Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Dec 13, 2022
- It doesn't belong to this PR
@mdimjasevic mdimjasevic temporarily deployed to cachix December 13, 2022 15:03 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix December 13, 2022 15:03 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix December 13, 2022 15:24 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix December 13, 2022 15:24 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix December 13, 2022 16:02 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix December 13, 2022 16:02 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic merged commit 64b8d60 into develop Dec 13, 2022
@mdimjasevic mdimjasevic deleted the mdimjasevic/fs-901-mv-fed-api-types branch December 13, 2022 19:30
smatting added a commit that referenced this pull request Dec 15, 2022
…sage sending request types (#2925)"

This reverts commit 64b8d60.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants