[FS-1249] Do Not List MLS Self-conversation in client API v1 and v2 #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
elland
reviewed
Nov 28, 2022
| @@ -398,6 +406,22 @@ conversationIdsPageFromV2 lusr Public.GetMultiTablePageRequest {..} = do | |||
| mtpPagingState = Public.ConversationPagingState table (LBS.toStrict . C.unPagingState <$> pwsState) | |||
| } | |||
|
|
|||
| -- MLS self-conversation of this user | |||
| selfConvId = mlsSelfConvId (tUnqualified lusr) | |||
| isNotSelfConv = (/= selfConvId) . qUnqualified | |||
There was a problem hiding this comment.
How about the global team conversation?
There was a problem hiding this comment.
I'd suggest to do that in a separate PR. I suppose it won't be hard to add it on top of this (assuming it gets merged), but you would know best.
smatting
approved these changes
Nov 28, 2022
2 tasks
This was referenced Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the call to
POST /conversation/list-idswill list the MLS self-conversation in client API v1 and v2 if a v3 client created the conversation. Filter out the conversation in versions below v3.Tracked by https://wearezeta.atlassian.net/browse/FS-1249.
Checklist
changelog.d